search

terraform-routeros / terraform-provider-routeros

Terraform Provider for Mikrotik RouterOS
Mozilla Public License 2.0
165 stars 46 forks source link

feat: add comment to routeros_wifi resource #455

Closed redcancode closed 1 month ago

redcancode commented 1 month ago

I wanted to manage the wifi interfaces on my router and I noticed that the comment property isn't part of the routeros_wifi resource schema. So I thought I add it. I've tested it by locally building the binary and running it with terraform, everything seemed to worked correctly.

This is my first contribution to this repository. I haven't found any rules in the repo so I hope this pull request is okay. Let me know if I should change something or add something.

vaerh commented 1 month ago

Everything is perfect. Thanks for the PR. The only point, the generation of documentation is automatic with each release. You may not have to make changes to these files in the future.

vaerh commented 1 month ago

:tada: This PR is included in version 1.48.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

redcancode commented 1 month ago

Thanks for the merge and release. 🥹 I didn't know about the generated documentation, I will watch out for that, thanks. 👍🏻