terraform-routeros / terraform-provider-routeros

Terraform Provider for Mikrotik RouterOS
Mozilla Public License 2.0
190 stars 54 forks source link

Default and current values shown as a plan diff until recorded in state #466

Closed OJFord closed 4 months ago

OJFord commented 4 months ago

If you don't specify routeros_ip_dhcp_server's bootp_support and import the default configuration, it is already "static" but a subsequent terraform plan will show:

      + bootp_support = "static"

which will have no effect on the device, just set the state to what it already was at time of import.

Similar happens with routeros_interface_bridge: by default VLAN filtering is disabled, and the following plan will want to set all the default VLAN filtering values (0x8100, PVID 1, admit-all) which are visible if you toggle it on in WebFig, and already set (and default) but not imported.

It doesn't have any effect of course since it's disabled anyway, it's just not expected that there would be a diff in the plan when those are the current values, the provider's defaults are correct, it's just not recognising that they're already set if the feature's disabled.

vaerh commented 4 months ago

:tada: This issue has been resolved in version 1.52.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: