search

terraformer-js / terraformer

A geographic toolkit for dealing with geometry, geography, formats, and building geodatabases
MIT License
187 stars 28 forks source link

lasso feedback/questions #33

Closed jgravois closed 2 years ago

jgravois commented 4 years ago

intersects(polygon, point) returns true if point is inside polygon, but throws "Type Polygon to Point intersection is not supported by intersects" if it is not inside. Obviously it is an issue of not respecting false return value at the same line as above, but it is correct false in this case. This issue exists also in the original Terraformer, I just ignored it and forced to use contains with points (https://github.com/zakjan/leaflet-lasso/blob/master/src/calc.ts#L47-L49). Is there possibly another way of detecting that intersection is not supported? What specific combination of types is actually not supported?

createCircle still returns incorrrect radius and it is missing export. But I can stay with the other dependency.

jgravois commented 2 years ago

tracking in #71