Closed Zakhmaster closed 1 year ago
Seems like when I ran npm run release
it changed line endings in a bunch of files causing the diff to show many changes. I will try to fix that.
very cool contribution @Zakhmaster. i should be able to review it more fully within a week or so.
Seems like when I ran
npm run release
it changed line endings in a bunch of files causing the diff to show many changes. I will try to fix that.
you're not going to be able to publish these changes to npm. generally i'm a proponent of bumping version numbers and prepping for a release after PRs with new features or bug fixes are merged.
thx again for the PR and tweaks @Zakhmaster! i'd usually be able to help land something like this quickly, but i have a few too many plates in the air at the moment. 🤹
in the meantime, thanks for being patient.
thx again for the PR and tweaks @Zakhmaster! i'd usually be able to help land something like this quickly, but i have a few too many plates in the air at the moment. 🤹
in the meantime, thanks for being patient.
Hey, no need to rush. It is not critical for me.
I am not sure what to do about the merge checks. If there is something I can do to get those passing let me know.
@jgravois I think I have addressed all of the comments? Let me know!
Added the ability to convert WKT Geometry Collection to a GeoJSON Geometry Collection. Required simple changes to the Yacc file and a few helper functions.
Added tests for most subsets of possible geometries in the collection Added tests for empty collection Added tests for Z and/or M properties Added test to cover scenario of a collection inside of a collection