terraframe / geoprism-registry

GeoPrism Registry is a system for curating interlinked data through time. It's the first framework implementing the Common Geo-Registry specification.
https://geoprismregistry.com/
GNU Lesser General Public License v3.0
18 stars 5 forks source link

When viewing a Geo-Object from a published list in the Explorer, only that Geo-Object is shown in the attribute table, while all Geo-Objects in the list are shown on the map #862

Closed rfromthecastle closed 1 year ago

rfromthecastle commented 1 year ago

List the CGR information

Describe the bug (clear and concise) When viewing a Geo-Object from a published list in the Explorer, only that Geo-Object is shown in the attribute table, while all Geo-Objects in the list are shown on the map

To Reproduce

  1. As a Registry Maintainer, open a published list
  2. Open a Geo-Object in the Explorer
  3. The given Geo-Object only is listed in the attribute table, but the map shows all Geo-Objects in the list

Expected behavior (clear and concise) The map only shows the selected Geo-Object or zooms into it.

Screenshots image.png

Desktop (please complete the following information):

Additional context (if any) None

rfromthecastle commented 1 year ago

Low priority bug, as only causes a minor inconvenience to the user

SteeveEbener commented 1 year ago

@rfromthecastle : I don't think this is a bug but actually something that has been decided upon in order for the user to be able to "locate" the geo-object in question among the other ones of the same type and I think this should remain as it is now.

The geo-object in question should nevertheless be highlighted to be able to identify it on the map.

rrowlands commented 1 year ago

Fixed as a8c6c0441d9f47107b6e0367c9ab01d8c2281d8f

@SteeveEbener This fix is now on the staging server if you would like to see the changes I have made. Mostly I aligned the list selection behavior with the Geo-Object selection. The system now renders all the list data and also highlights and zooms to the object in question. This should give us the best of both of your requirements.

rfromthecastle commented 1 year ago

Fix tested on Staging and working well :) Thanks both!

SteeveEbener commented 1 year ago

Thanks. Could this be pushed to the sandbox? Thanks

rrowlands commented 1 year ago

@SteeveEbener This fix was included in the 1.0.0 release, which was pushed to the demo server on Dec 3.

SteeveEbener commented 1 year ago

The UI is now the same in both the sandbox and staging.

This being said, what happens is not what you are describing in your Nov 24th comment as only the geo-object you selected is appearing on the map, not the other ones. Here is for example what you get when logged in as the MOH RA and opening the Hillary Avila community health worker: image

The other community health workers are not appearing on the map (and this is on both staging and demo) while it should be the case

rrowlands commented 1 year ago

Hi Steeve, I agree this is an issue for working lists.

rrowlands commented 1 year ago

Addressed as 0b5d79fdb508c2b40204ab9e47805cf174cac3ba.

SteeveEbener commented 1 year ago

Can we please close tickets when they have been checked by the person who submitted them? thanks

rfromthecastle commented 1 year ago

All the requested fixes are working as expected on Staging