search

terraframe / geoprism-registry

GeoPrism Registry is a system for curating interlinked data through time. It's the first framework implementing the Common Geo-Registry specification.
https://geoprismregistry.com/
GNU Lesser General Public License v3.0
18 stars 5 forks source link

Duplicate inherited parent Geo-Object Types displayed in DHIS2 synchronization configuration #896

Closed rfromthecastle closed 1 year ago

rfromthecastle commented 1 year ago

List the CGR information

Describe the bug (clear and concise) When I set up a DHIS2 synchronization configuration based on a hierarchy with inherited parent Geo-Objects, the Geo-Object Type that inherits parent Geo-Object Types appears twice in the Geo-Object Type selection dropdown when mapping these onto organization unit levels (e.g., provincial hospital located within a province, which inherits the country, with the province appearing twice), and other Geo-Object Types from the inherited hierarchy that are below the level from which the inheritance was made also show up (e.g., the district also showing up in the dropdown).

To Reproduce

  1. As a Registry Administrator, create a hierarchy with inherited parent Geo-Object Types.
  2. Via the Settings module, set up a DHIS2 synchronization configuration based on this hierarchy.
  3. When mapping the Geo-Object Types onto levels, the Geo-Object Type that inherits parent Geo-Object Types appears twice in the dropdown.

Expected behavior (clear and concise) Each Geo-Object Type in the hierarchy appears only once.

Screenshots image image

Desktop (please complete the following information):

Additional context (if any) None

rrowlands commented 1 year ago

Fix committed as c45c72aaa0ffca1bbba2577779fc61ba3eff40bf.