terraframe / geoprism-registry

GeoPrism Registry is a system for curating interlinked data through time. It's the first framework implementing the Common Geo-Registry specification.
https://geoprismregistry.com/
GNU Lesser General Public License v3.0
18 stars 5 forks source link

Error message details empty for external system synchronization #909

Closed rfromthecastle closed 1 year ago

rfromthecastle commented 1 year ago

List the CGR information

Describe the bug (clear and concise) The error message details are empty when an external system synchronization fails.

To Reproduce

  1. As a Registry Administrator, run a synchronization that causes an error.
  2. Click on details.
  3. The table with error details is empty.

Expected behavior (clear and concise) Details of the error are provided.

Screenshots image

Desktop (please complete the following information):

Additional context (if any)

rrowlands commented 1 year ago

Looks like the root cause here is the same corrupt data in the DHIS2 database, first discovered here: https://github.com/terraframe/geoprism-registry/issues/898#issuecomment-1507467413

If this was working in the past, it could be because the updated DHIS2 software is doing better validation of the translations (but hasn't patched out the existing corrupt data).

The following request: https://dhis2.asia/laohmis/api/metadata.json?organisationUnits=true&filter=id:eq:HTCt5PAPTQN

Reveals that there is an existing "description" translation without any locale:

{
  "property": "DESCRIPTION",
  "value": "ສຮສກ (ສາງໂຮງໝໍສູນກາງ)"
},

When our system attempts to submit changes to unrelated data, the DHIS2 notices the existing corrupt data and throws an error.

I will do the following:

  1. Improve our sync page so that it doesn't glitch out as described in this ticket
  2. Clean up the data as it passes through our system so that DHIS2 won't reject it when it comes back in.
rfromthecastle commented 1 year ago

Having difficulty replicating the bug on Staging and re-testing, so will only be able to test and confirm the fix is working once deployed to the Laos instance.

rfromthecastle commented 1 year ago

Working on the Laos instance. Thanks for fixing!