search

terrajobst / nquery-vnext

A Roslyn inspired rewrite of NQuery
MIT License
72 stars 16 forks source link

Fix `async void` usages to follow guidelines, and fix two bugs along the way #58

Open dallmair opened 2 years ago

dallmair commented 2 years ago

Rename async void methods to have Async suffix and return tasks all the way up to constructors/event handlers.

In SignatureHelpManager.UpdateSessionAsync, add the missing await to UpdateModelAsync call and a check for null session after updating the model.

Fixes #55. Fixes #56.