terrajobst / nquery-vnext

A Roslyn inspired rewrite of NQuery
MIT License
72 stars 16 forks source link

Use invariant culture for conversions in built-in `CONCAT` aggregate #63

Closed dallmair closed 6 months ago

dallmair commented 6 months ago

Similarly to #57, the CONCAT aggregate should default to invariant culture for its string conversion.

In case someone wants to use culture-specific conversion of numbers, that will still be possible with a nested conversion, so there is no reduction of functionality: CONCAT(TO_STRING(table.NumberColumn, 'fr-fr'))

(Also, there was a potential NullReferenceException as object.ToString is allowed to return null.)