terramate-io / terramate

Terramate CLI is an open-source Infrastructure as Code (IaC) Orchestration and Code Generation tool for Terraform, OpenTofu and Terragrunt.
https://terramate.io
Mozilla Public License 2.0
3.24k stars 91 forks source link

[BUG] scanning terragrunt modules scanning hidden directory and not honoring .tmskip marker #1656

Open doug-lethin-simplisafe opened 5 months ago

doug-lethin-simplisafe commented 5 months ago

Describe the bug Calling terramate list --changed navigates hidden directories while scanning for terragrunt modules fails if it encounters a problem with a file its found. Placing a .tmskip in that directory doesn't help.

For reasons I think are not relevant here, we currently have a submodule as part of our terragrunt repo which has some terragrunt infrastructure in it, but it's not referenced or used by our terramate infrastructure. However, its presence as a submodule is causing problems because terramate trys to scan it.

I thought placing a .tmskip empty marker file in the .submodules directory would get it to be ignored but that doesn't work.

See error below.

thanks.

Expected behavior I would expect terramate to either ignore directories that are hidden or honor the .tmskip marker

Log Output terramate list --changed Error: listing changed stacks error: scanning terragrunt modules: parsing Terragrunt file: /[REDACTED]/.submodules/[REDACTED]/_directory_templates/TEAM_OU_NAME/[REDACTED]/terragrunt.hcl:3,15-38: Error in function call; Call to function "find_in_parent_folders" failed: ParentFileNotFoundError: Could not find a account_remote_state.hcl in any of the parent folders of /[REDACTED]/.submodules/[REDACTED]/_directory_templates/TEAM_OU_NAME/[REDACTED]/terragrunt.hcl. Cause: Traversed all the way to the root.., and 1 other diagnostic(s) (and 21 elided errors) Environment (please complete the following information):

mariux commented 5 months ago

Thanks for letting us know. we are working on a fix and will provide a solution asap.

i4ki commented 5 months ago

Hey @doug-lethin-simplisafe

We released v0.6.5 with support for disabling the Terragrunt change detection for now.

We are working in improvements in the Terragrunt change detection to support .tmskip and we will let you know here when released.

Thank you.

doug-lethin-simplisafe commented 5 months ago

Thanks. tried this out and it works great. appreciate the quick turnaround.

JesalHaria commented 3 months ago

hi just wondering, is there a proper fix for this now? I'm exploring the viability of terramate's change detection in our terragrunt stack to speed up our plans/applies as they currently take a long time to execute. I'm currently having this issue as well, and It seems like if it's not fixed/fixable then terramate won't be a viable option for us. Thanks!