search

terramate-io / terramate

Terramate CLI is an open-source Infrastructure as Code (IaC) Orchestration and Code Generation tool for Terraform, OpenTofu and Terragrunt.
https://terramate.io
Mozilla Public License 2.0
3.12k stars 86 forks source link

fix: incorrect warnings emitted by the parser. #1675

Closed i4ki closed 2 months ago

i4ki commented 2 months ago

What this PR does / why we need it:

Fix incorrect warnings emitted by the parser when terramate.config.run.env is declared in child directories.

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

Does this PR introduce a user-facing change?

github-actions[bot] commented 2 months ago 
metric: time/op
CloudReadLines-4: old 1.02ms ± 4%: new 1.01ms ± 4%: delta: -1.30%
CloudReadLine-4: old 7.29ms ± 2%: new 7.29ms ± 2%: delta: 0.00%
ListFiles-4: old 52.4µs ± 3%: new 51.9µs ± 1%: delta: 0.00%
Generate-4: old 2.62s ± 2%: new 2.56s ± 2%: delta: -2.22%
GenerateRegex-4: old 1.76s ± 3%: new 1.74s ± 2%: delta: -0.87%
TokensForExpressionComplex-4: old 1.27ms ± 1%: new 1.26ms ± 1%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 894ns ± 1%: new 894ns ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 21.9µs ± 1%: new 21.8µs ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.46ms ± 0%: new 1.45ms ± 1%: delta: -0.67%
TokensForExpression-4: old 1.27ms ± 1%: new 1.26ms ± 1%: delta: -0.75%
PartialEvalComplex-4: old 436µs ± 1%: new 434µs ± 1%: delta: -0.37%
PartialEvalSmallString-4: old 3.63µs ± 1%: new 3.62µs ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 1.88ms ± 1%: new 1.88ms ± 1%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.94ms ± 1%: new 4.96ms ± 2%: delta: 0.00%
PartialEvalObject-4: old 21.7µs ± 1%: new 21.7µs ± 1%: delta: 0.00%
TmAllTrueLiteralList-4: old 6.27ms ± 1%: new 6.32ms ± 1%: delta: 0.80%
TmAllTrueFuncall-4: old 161µs ± 1%: new 163µs ± 1%: delta: 1.09%
TmAnyTrueLiteralList-4: old 147ms ± 1%: new 149ms ± 1%: delta: 1.11%
TmAnyTrueFuncall-4: old 162µs ± 1%: new 163µs ± 1%: delta: 0.65%
TmTernary-4: old 2.84µs ± 1%: new 2.83µs ± 1%: delta: -0.48%
TmTry-4: old 52.0µs ± 1%: new 52.6µs ± 1%: delta: 1.19%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 22.0kB ± 0%: delta: 0.00%
Generate-4: old 2.32GB ± 0%: new 2.32GB ± 0%: delta: -0.00%
GenerateRegex-4: old 955MB ± 0%: new 956MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 412kB ± 0%: new 412kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.4kB ± 0%: new 12.4kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 402kB ± 0%: new 402kB ± 0%: delta: -0.00%
TokensForExpression-4: old 412kB ± 0%: new 412kB ± 0%: delta: -0.00%
PartialEvalComplex-4: old 356kB ± 0%: new 356kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 1.74MB ± 0%: new 1.74MB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 45.5kB ± 0%: new 45.5kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 37.9MB ± 0%: new 37.9MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 45.6kB ± 0%: new 45.6kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTry-4: old 11.2kB ± 0%: new 11.2kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: -0.01%
GenerateRegex-4: old 18.6M ± 0%: new 18.6M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 228 ± 0%: new 228 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.29k ± 0%: new 3.29k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: -0.01%
PartialEvalComplex-4: old 2.86k ± 0%: new 2.86k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 125 ± 0%: new 125 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 13.6k ± 0%: new 13.6k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 460 ± 0%: new 460 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 252k ± 0%: new 252k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 462 ± 0%: new 462 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTry-4: old 147 ± 0%: new 147 ± 0%: delta: 0.00%
snakster commented 2 months ago

I did some testing and the warnings are gone in the scenarios I tried, but when adding a disallowed block at the non-root level, the warning says ... Edit: Oops, my bad, I got something mixed up during testing. The output is as expected, discard this comment.