search

terramate-io / terramate

Terramate CLI is an open-source Infrastructure as Code (IaC) Orchestration and Code Generation tool for Terraform, OpenTofu and Terragrunt.
https://terramate.io
Mozilla Public License 2.0
3.12k stars 86 forks source link

fix: run.env not including complete env var. #1711

Closed i4ki closed 1 month ago

i4ki commented 1 month ago

What this PR does / why we need it:

Fixes a bug in the processing of Go's environ, which has the form NAME=VALUE but the value can also contain equal signs.

Which issue(s) this PR fixes:

Fixes #1710

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes a bug.
github-actions[bot] commented 1 month ago 
metric: time/op
CloudReadLines-4: old 1.00ms ± 6%: new 0.98ms ± 5%: delta: -2.26%
CloudReadLine-4: old 7.15ms ± 3%: new 7.14ms ± 3%: delta: 0.00%
ListFiles-4: old 51.7µs ± 2%: new 51.7µs ± 1%: delta: 0.00%
Generate-4: old 2.50s ± 1%: new 2.49s ± 2%: delta: 0.00%
GenerateRegex-4: old 1.72s ± 1%: new 1.70s ± 2%: delta: -1.00%
TokensForExpressionComplex-4: old 1.26ms ± 2%: new 1.26ms ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 881ns ± 1%: new 884ns ± 1%: delta: 0.41%
TokensForExpressionStringWith100Newlines-4: old 21.6µs ± 1%: new 21.9µs ± 1%: delta: 1.18%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.45ms ± 1%: new 1.45ms ± 0%: delta: 0.00%
TokensForExpression-4: old 1.25ms ± 2%: new 1.26ms ± 0%: delta: 0.00%
PartialEvalComplex-4: old 426µs ± 2%: new 428µs ± 2%: delta: 0.00%
PartialEvalSmallString-4: old 3.54µs ± 2%: new 3.59µs ± 1%: delta: 1.27%
PartialEvalHugeString-4: old 1.87ms ± 1%: new 1.87ms ± 1%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.89ms ± 2%: new 4.91ms ± 1%: delta: 0.00%
PartialEvalObject-4: old 21.4µs ± 2%: new 21.6µs ± 1%: delta: 0.72%
TmAllTrueLiteralList-4: old 6.22ms ± 2%: new 6.25ms ± 1%: delta: 0.43%
TmAllTrueFuncall-4: old 160µs ± 1%: new 158µs ± 2%: delta: -1.10%
TmAnyTrueLiteralList-4: old 147ms ± 0%: new 146ms ± 2%: delta: 0.00%
TmAnyTrueFuncall-4: old 160µs ± 1%: new 160µs ± 2%: delta: 0.00%
TmTernary-4: old 2.82µs ± 2%: new 2.78µs ± 1%: delta: -1.18%
TmTry-4: old 51.8µs ± 1%: new 51.6µs ± 2%: delta: 0.00%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 22.0kB ± 0%: delta: 0.00%
Generate-4: old 2.32GB ± 0%: new 2.32GB ± 0%: delta: 0.00%
GenerateRegex-4: old 955MB ± 0%: new 955MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 412kB ± 0%: new 412kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.4kB ± 0%: new 12.4kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 402kB ± 0%: new 402kB ± 0%: delta: 0.00%
TokensForExpression-4: old 412kB ± 0%: new 412kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 356kB ± 0%: new 356kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 1.74MB ± 0%: new 1.74MB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 45.5kB ± 0%: new 45.5kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 37.9MB ± 0%: new 37.9MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 45.6kB ± 0%: new 45.6kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTry-4: old 11.2kB ± 0%: new 11.2kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.6M ± 0%: new 18.6M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.01%
TokensForExpressionPlainStringNoNewline-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 228 ± 0%: new 228 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.29k ± 0%: new 3.29k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: -0.01%
PartialEvalComplex-4: old 2.86k ± 0%: new 2.86k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 125 ± 0%: new 125 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 13.6k ± 0%: new 13.6k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 460 ± 0%: new 460 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 252k ± 0%: new 252k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 462 ± 0%: new 462 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTry-4: old 147 ± 0%: new 147 ± 0%: delta: 0.00%