search

terramate-io / terramate

Terramate CLI is an open-source Infrastructure as Code (IaC) Orchestration and Code Generation tool for Terraform, OpenTofu and Terragrunt.
https://terramate.io
Mozilla Public License 2.0
3.12k stars 85 forks source link

perf: remove misused function which re-parsed rootdir. #1757

Closed i4ki closed 1 week ago

i4ki commented 2 weeks ago

What this PR does / why we need it:

Remove config.LoadTree() because all usages of it led to re-parsing of the rootdir. The only real need was in the config.LoadRoot() then its code was moved there.

This change is important for a (maybe) upcoming feature for generating TM files itself, that heavily depend on config.LoadSubTree() which called config.LoadTree() and then surplus calls to hcl.ParseDir() were incurred each time.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no
github-actions[bot] commented 2 weeks ago 
metric: time/op
CloudReadLines-4: old 1.03ms ± 4%: new 0.98ms ± 6%: delta: -5.20%
CloudReadLine-4: old 7.12ms ± 2%: new 7.21ms ± 2%: delta: 1.28%
ListFiles-4: old 53.1µs ± 1%: new 54.0µs ± 1%: delta: 1.77%
Generate-4: old 2.62s ± 2%: new 2.69s ± 1%: delta: 2.83%
GenerateRegex-4: old 1.72s ± 1%: new 1.83s ± 2%: delta: 6.65%
TokensForExpressionComplex-4: old 1.24ms ± 0%: new 1.26ms ± 1%: delta: 1.47%
TokensForExpressionPlainStringNoNewline-4: old 780ns ± 1%: new 787ns ± 1%: delta: 0.87%
TokensForExpressionStringWith100Newlines-4: old 21.6µs ± 1%: new 22.1µs ± 1%: delta: 2.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.44ms ± 1%: new 1.46ms ± 1%: delta: 1.57%
TokensForExpression-4: old 1.25ms ± 1%: new 1.27ms ± 1%: delta: 1.59%
PartialEvalComplex-4: old 577µs ± 1%: new 587µs ± 2%: delta: 1.82%
PartialEvalSmallString-4: old 3.59µs ± 1%: new 3.67µs ± 1%: delta: 2.14%
PartialEvalHugeString-4: old 1.88ms ± 0%: new 1.89ms ± 0%: delta: 0.91%
PartialEvalHugeInterpolatedString-4: old 4.94ms ± 1%: new 5.14ms ± 1%: delta: 4.06%
PartialEvalObject-4: old 24.2µs ± 1%: new 25.0µs ± 1%: delta: 3.46%
TmAllTrueLiteralList-4: old 6.27ms ± 1%: new 6.41ms ± 1%: delta: 2.25%
TmAllTrueFuncall-4: old 161µs ± 1%: new 165µs ± 1%: delta: 2.52%
TmAnyTrueLiteralList-4: old 148ms ± 1%: new 151ms ± 1%: delta: 2.08%
TmAnyTrueFuncall-4: old 161µs ± 1%: new 163µs ± 3%: delta: 1.17%
TmTernary-4: old 2.86µs ± 2%: new 2.87µs ± 1%: delta: 0.00%
TmTry-4: old 52.2µs ± 1%: new 52.3µs ± 1%: delta: 0.35%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 22.0kB ± 0%: delta: 0.00%
Generate-4: old 2.32GB ± 0%: new 2.32GB ± 0%: delta: 0.00%
GenerateRegex-4: old 955MB ± 0%: new 955MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 404kB ± 0%: new 404kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.4kB ± 0%: new 12.4kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpression-4: old 404kB ± 0%: new 404kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 408kB ± 0%: new 408kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: -0.00%
PartialEvalObject-4: old 21.9kB ± 0%: new 21.9kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 1.74MB ± 0%: new 1.74MB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 45.5kB ± 0%: new 45.5kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 37.9MB ± 0%: new 37.9MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 45.6kB ± 0%: new 45.6kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTry-4: old 11.2kB ± 0%: new 11.2kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.6M ± 0%: new 18.6M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.84k ± 0%: delta: 0.01%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.84k ± 0%: delta: 0.02%
PartialEvalComplex-4: old 3.65k ± 0%: new 3.65k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 153 ± 0%: new 153 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 13.6k ± 0%: new 13.6k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 460 ± 0%: new 460 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 252k ± 0%: new 252k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 462 ± 0%: new 462 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTry-4: old 147 ± 0%: new 147 ± 0%: delta: 0.00%