github-actions[bot]
commented
1 week ago metric: time/op
CloudReadLines-4: old 1.01ms ± 6%: new 0.97ms ± 6%: delta: -4.24%
CloudReadLine-4: old 7.05ms ± 1%: new 7.03ms ± 1%: delta: -0.42%
ListFiles-4: old 53.0µs ± 1%: new 53.0µs ± 1%: delta: 0.00%
Generate-4: old 2.54s ± 1%: new 2.58s ± 3%: delta: 1.31%
GenerateRegex-4: old 1.72s ± 1%: new 1.71s ± 1%: delta: -0.42%
TokensForExpressionComplex-4: old 1.24ms ± 0%: new 1.24ms ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 777ns ± 0%: new 780ns ± 1%: delta: 0.38%
TokensForExpressionStringWith100Newlines-4: old 21.5µs ± 1%: new 21.5µs ± 1%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.43ms ± 0%: new 1.44ms ± 0%: delta: 0.00%
TokensForExpression-4: old 1.25ms ± 0%: new 1.25ms ± 0%: delta: 0.00%
PartialEvalComplex-4: old 576µs ± 1%: new 576µs ± 1%: delta: 0.00%
PartialEvalSmallString-4: old 3.59µs ± 0%: new 3.59µs ± 0%: delta: 0.17%
PartialEvalHugeString-4: old 1.87ms ± 0%: new 1.87ms ± 0%: delta: -0.22%
PartialEvalHugeInterpolatedString-4: old 4.97ms ± 1%: new 4.93ms ± 1%: delta: -0.80%
PartialEvalObject-4: old 24.2µs ± 1%: new 24.2µs ± 1%: delta: 0.00%
TmAllTrueLiteralList-4: old 6.26ms ± 0%: new 6.26ms ± 0%: delta: -0.11%
TmAllTrueFuncall-4: old 161µs ± 1%: new 160µs ± 0%: delta: -0.16%
TmAnyTrueLiteralList-4: old 147ms ± 0%: new 147ms ± 0%: delta: -0.13%
TmAnyTrueFuncall-4: old 161µs ± 0%: new 161µs ± 0%: delta: 0.00%
TmTernary-4: old 2.86µs ± 1%: new 2.85µs ± 0%: delta: -0.38%
TmTry-4: old 52.0µs ± 0%: new 51.9µs ± 0%: delta: -0.19%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 22.0kB ± 0%: delta: 0.00%
Generate-4: old 2.32GB ± 0%: new 2.32GB ± 0%: delta: 0.00%
GenerateRegex-4: old 955MB ± 0%: new 955MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 404kB ± 0%: new 404kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.4kB ± 0%: new 12.4kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpression-4: old 404kB ± 0%: new 404kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 408kB ± 0%: new 408kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 21.9kB ± 0%: new 21.9kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 1.74MB ± 0%: new 1.74MB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 45.5kB ± 0%: new 45.5kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 37.9MB ± 0%: new 37.9MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 45.6kB ± 0%: new 45.6kB ± 0%: delta: 0.00%
TmTernary-4: old 1.20kB ± 0%: new 1.20kB ± 0%: delta: 0.00%
TmTry-4: old 11.2kB ± 0%: new 11.2kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 321 ± 0%: delta: 0.00%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.6M ± 0%: new 18.6M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.65k ± 0%: new 3.65k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 153 ± 0%: new 153 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 13.6k ± 0%: new 13.6k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 460 ± 0%: new 460 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 252k ± 0%: new 252k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 462 ± 0%: new 462 ± 0%: delta: 0.00%
TmTernary-4: old 28.0 ± 0%: new 28.0 ± 0%: delta: 0.00%
TmTry-4: old 147 ± 0%: new 147 ± 0%: delta: 0.00%
What this PR does / why we need it:
This PR fixes a crash due to a missing bounds check when parsing a tag list that contains a trailing comma.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?