search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
234 stars 89 forks source link

Remove unnecessary `isotopicDepletion` stub #1458

Closed keckler closed 7 months ago

keckler commented 1 year ago

This file is not useful. If a user wants to use the STACK_ORDER.DEPLETION constant, they can just use it directly from the interfaces module. None of the other imports in this file are used.

https://github.com/terrapower/armi/blob/9da65879499bda3b9f1e9829e3d9f935275eeaa7/armi/physics/neutronics/isotopicDepletion/__init__.py#L15-L23

Unfortunately we have an internal plugin that directly imports ORDER from here. So we can't just delete this. But it should be slated for removal.

keckler commented 1 year ago

Same goes for the stub in latticePhysics: https://github.com/terrapower/armi/blob/c7995865ca66d97eefaeb958148aa758358e479c/armi/physics/neutronics/latticePhysics/__init__.py#L15-L24

EDIT: This will go away if https://github.com/terrapower/armi/pull/1479 is merged.

john-science commented 8 months ago

@keckler @albeanth

Okay, I understand this file is mostly empty. And I would like to remove it.

I can only find one place where this stub is used downstream, and I have opened a ticket there. When THAT is cleaned up, we can happily remove this stub.

john-science commented 8 months ago

@keckler As we are going to move the entire latticePhysics package out of ARMI, I am not so concerned about the second stub you mention.