search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
234 stars 89 forks source link

Coverage for uniform mesh converter #1538

Closed keckler closed 8 months ago

keckler commented 11 months ago

The coverage went down because the tests for nonuniform assembly conversion in the global flux interface used to exercise the geometry converter. The tests in question:

https://github.com/bsculac/armi/blob/366afec6121d0056545a8db0127a52d6116014f1/armi/physics/neutronics/globalFlux/tests/test_globalFluxInterface.py#L312

and https://github.com/bsculac/armi/blob/366afec6121d0056545a8db0127a52d6116014f1/armi/physics/neutronics/globalFlux/tests/test_globalFluxInterface.py#L231

It is inappropriate for those tests to test the uniform mesh converter, and the test coverage went down when I narrowed the scope of the test.

Originally posted by @bsculac in https://github.com/terrapower/armi/issues/1536#issuecomment-1847863284

john-science commented 8 months ago

A lot of time has passed since this ticket was opened, so I don't know the uniformMesh.py now has 91.5% code coverage.

So, I will close this ticket.

(Also, the code coverage on global flux is 84% now.)