terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
214 stars 82 forks source link

FluxFiles Deserve Hashes Too! #1613

Closed opotowsky closed 5 months ago

opotowsky commented 5 months ago

What is the change?

Adding fluxFiles to one of the crossSectionControl items that is gifted with a SHA.

Why is the change being made?

We want to be able to trace inputs such as these internally.


Checklist

mgjarrett commented 5 months ago

@opotowsky it looks good to me. I don't think we need any changes to the code you added, but I did leave a comment about potentially changing some of the pre-existing variable names.

opotowsky commented 5 months ago

Ok I just reran the case submission internally and our hashes are lookin good! @john-science this can go in whenever you want it to (fine to push it to after the impl PRs are in)

john-science commented 5 months ago

I retroactively approve this PR. :)