search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
224 stars 87 forks source link

Remove unused `rotationDegreesCCW` argument #1623

Closed albeanth closed 2 months ago

albeanth commented 8 months ago

While doing a review for #1619, I found that the argument rotationDegreesCCW is unused -- and I don't see any downstream projects that use it. So I think it's ripe for removal.

https://github.com/terrapower/armi/blob/3d49274d8334b166e3a923770b4f4991333f6d69/armi/reactor/blocks.py#L597 https://github.com/terrapower/armi/blob/3d49274d8334b166e3a923770b4f4991333f6d69/armi/reactor/blocks.py#L1623

john-science commented 8 months ago

I checked downstream, and I can confirm that no one is using this argument. This should is safe to remove.

andfranklin commented 2 months ago

Looks like this was recently removed. Ran git grep rotationDegreesCCW to confirm.