Closed AidanMcDonald closed 2 weeks ago
Adding a unit test to prove the idea would be nice.
@AidanMcDonald Last I saw, you were able to continue with your work without this PR. Does that mean this PR isn't necessary?
Correct, this PR is not necessary anymore. Sorry, I forgot to close this earlier. Please reject/abandon this PR. Thanks!
Closing this PR as unnecessary. Thanks, Aidan!
What is the change?
blockConverter._verifyExpansion()
was throwing an error when the solvent was aderivedShape
Component becauseisEncapsulatedBy
requires the "other" component to have an"od"
Parameter. I believe this check doesn't make sense for aderivedShape
Component, so I added a simple check to skip theisEncapsulatedBy
call in this case.Why is the change being made?
This change is necessary for using the openmc plugin. Openmc cannot handle helix components so the openmc input writer uses
MultipleComponentMerger
, in which this bug arose.Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.pyproject.toml
.