Removing unused method HexGrid.allPositionsInThird - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

224 stars 87 forks source link

Removing unused method HexGrid.allPositionsInThird #1655

Closed john-science closed 7 months ago

john-science commented 7 months ago

What is the change?

Removing an unused method.

Why is the change being made?

This method has never been used by ARMI or any downstream project (except one) in the last 4-5 years. So I am moving it to the downstream project.

I find this method to be a bit too specific to have in the HexGrid class.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 7 months ago

@opotowsky I have opened a parallel PR downstream, that you should see.