Increasing Code Coverage - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

214 stars 82 forks source link

Increasing Code Coverage #1656

Closed john-science closed 4 months ago

john-science commented 4 months ago

What is the change?

I added code coverage to:

CaseSuite.compare()
Assembly.getBIndexFromZIndex()
Assembly.getElevationBoundariesByBlockType()

An I removed two unused methods:

Reactor.getAllNuclidesIn()
armi.utils.plotting.plotTriangleFlux()

Why is the change being made?

I am just trying to increase our code coverage.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 4 months ago

Geez. Moving the needle on our code coverage is hard these days. Here's the end result of this PR:

COVERAGE: 89.098% (+0.3%) FROM 88.827%

https://coveralls.io/builds/66071414

At least the code coverage is up over 89%.