Changing constant params to Volume Integrated

mgjarrett commented 6 months ago

What is the change?

Reactivity coefficient parameters for the Doppler constant were configured with the ParamLocation.AVERAGE location attribute. These parameters are actually ParamLocation.VOLUME_INTEGRATED, so they are being changed.

Why is the change being made?

The Doppler constant for a given block is proportional to the size of the block. If two blocks were to be combined into one, the combined block Doppler constant would be the sum of the two smaller blocks:

b.p.rxFuelDopplerConstant = b1.p.rxFuelDopplerConstant + b2.p.rxFuelDopplerConstant

This is achieved with ParamLocation.VOLUME_INTEGRATED, not PararmLocation.AVERAGE.

The Doppler constant is directly related to the Doppler coefficient in units of pcm/K; the coefficients were already labeled as ParamLocation.VOLUME_INTEGRATED.

Checklist

[x] This PR has only one purpose or idea.
[ ] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

john-science commented 6 months ago

What's the status of this PR?

Nominally, it looks like you did what you wanted. Are you waiting to add a unit test or something?

john-science commented 3 months ago

@mgjarrett Can you put a short release note under the API Changes section? Thanks!

john-science commented 3 months ago

~It's odd this change doesn't require any unit tests changes, right?~

Okay, we have unit tests for things like "make sure VOLUME_INTEGRATED works", but not testing it for each Parameter. I guess that's the best idea I can come up with right now.

terrapower / armi