Closed john-science closed 1 day ago
Testing in all the downstream projects I can find, this is a pretty seamless change.
Since I preserved Database3
in the API, nearly everything works perfectly.
I only found one place where someone was doing a mock
of Database3
directly in a unit test in a place where Database
would be the new default. So, that one, ultra-specific unit test will need a one-line update.
This was about #1673
Too much time has passed, I will try to get to this PR again in August/September.
I still think this is a good idea.
What is the change?
This PR nominally renames
Database3
toDatabase
. But, since that is a big API-breaking change, this PR also creates API stubs fordatabase3.py
to fully support the old name.Why is the change being made?
Database3
was only ever meant to be a placeholder name, while ARMI made the switch from the oldDatabase
class to the new one. The name was supposed to be fixed ~6 years ago.Checklist
doc
folder.pyproject.toml
.