Fix `safeCopy` to work on Linux

opotowsky commented 2 months ago

What is the change?

Replace shutil.copyfile and shutil.copymode with a copy (windows) or cp (linux) command. This accomplishes the same thing as before (file copy with metadata).

We are NOT taking away the fact that safeCopy overrides shutil.copy in this PR, because there are significant downstream impacts and we need to check in with other ARMI users first. That is being tracked in the ticket #1690.

Why is the change being made?

Depending on how permissions are set up, this doesn't work on all linux systems.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

opotowsky commented 2 months ago

More internal testing/processes are needed before this can be merged, but it's ready for a review, at least

john-science commented 2 months ago

Yeah, let's remove the possible infinite loop of "while True" here and set a time for... I don't know, 30 or 60 minutes.

terrapower / armi