Moving .coveragerc info into pyproject.toml

john-science commented 5 months ago

What is the change?

I removed the .coveragerc file and adding that configuration into the pyproject.toml.

Why is the change being made?

Since we have moved the ARMI project to using pyproject.toml for everything else, it makes sense to do it also for this last feature. And it is the community standard these days.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 5 months ago

DO NOT MERGE

I want to do some careful by-line testing to make sure all the rules translated correctly to the new format.

opotowsky commented 5 months ago

DO NOT MERGE

I want to do some careful by-line testing to make sure all the rules translated correctly to the new format.

Feel free to re-request a review if you make big changes after testing. Looks good to me though!

john-science commented 5 months ago

Okay, the coverage results match, so this PR is safe to merge.

terrapower / armi