Open john-science opened 5 months ago
An Enum
/ Flag
might be nice for this versus a string!
We have a lot of mac users here despite it not being formally supported, it works well
We have a lot of mac users here despite it not being formally supported, it works well
Well, that's a wrench. Hmm
@drewejohnson I just tried to run the ARMI tests on MacOS and 18 of the 2064 tests failed:
https://github.com/terrapower/armi/actions/runs/8898351718/job/24435316299#step:5:2441
Most of the errors were of the form:
No such file or directory: 'refSmallReactor.yaml'
If that's an easy one to solve, maybe I could add MacOS to the official ARMI CI.
We have a lot of mac users here despite it not being formally supported, it works well
@drewejohnson Just FYI, I just opened a PR to support Macs: https://github.com/terrapower/armi/pull/1713
I believe the only functional solution would be something like:
context.py
, at "import armi" time, ARMI should determine if this system is Window. Linux, or Mac, and sets a global variable:armi.context.PLATFORM
.armi.context.PLATFORM
throughout the codebase.The goal here is to remove a ton of existing (and future) duplicate catches all around ARMI:
Instead we can do: