terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
232 stars 90 forks source link

Update uniform mesh converter to use optimal mesh size when material boundaries cannot be honored #1711

Open mgjarrett opened 5 months ago

mgjarrett commented 5 months ago

https://github.com/terrapower/armi/blob/cfc23356334253cb714171349f51acceb2db0225/armi/reactor/converters/uniformMesh.py#L192

The goal of axial mesh decusping is to honor important material boundaries in the uniform computational mesh; typically, these are the top and bottom of the fuel and absorber materials. The boundaries can be honored exactly as long as they are separated by more than the uniformMeshMinimumSize. When they are not separated by at least this distance, then the mesh from one of the material boundaries will be eliminated entirely from the axial mesh. It would be preferable to simply snap to the minimum mesh size in this case rather than removing the mesh point entirely.

I don't have any proposed implementation for this yet, I just want to document the thought.

jakehader commented 4 months ago

Good idea @mgjarrett

john-science commented 2 months ago

@mgjarrett Any movement on this?