terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
212 stars 82 forks source link

Fix units definition for gamma flux parameters #1712

Closed mgjarrett closed 1 month ago

mgjarrett commented 1 month ago

1352 updated the units defined for gamma flux parameters. The old parameter definitions used the letter g to represent "gamma", e.g. g/cm^2-s (c.f. n/cm^2-s for neutrons). When the units were converted, the g was replaced with units.GRAMS, which does technically produce the same string, but is confusing to somebody looking at the source code. Perhaps we should change this to p/cm^2-s (p for "photon") or just #/cm^2-s?

https://github.com/terrapower/armi/blob/cfc23356334253cb714171349f51acceb2db0225/armi/physics/neutronics/parameters.py#L89