1352 updated the units defined for gamma flux parameters. The old parameter definitions used the letter g to represent "gamma", e.g. g/cm^2-s (c.f. n/cm^2-s for neutrons). When the units were converted, the g was replaced with units.GRAMS, which does technically produce the same string, but is confusing to somebody looking at the source code. Perhaps we should change this to p/cm^2-s (p for "photon") or just #/cm^2-s?
1352 updated the units defined for gamma flux parameters. The old parameter definitions used the letter
g
to represent "gamma", e.g.g/cm^2-s
(c.f.n/cm^2-s
for neutrons). When the units were converted, theg
was replaced withunits.GRAMS
, which does technically produce the same string, but is confusing to somebody looking at the source code. Perhaps we should change this top/cm^2-s
(p
for "photon") or just#/cm^2-s
?https://github.com/terrapower/armi/blob/cfc23356334253cb714171349f51acceb2db0225/armi/physics/neutronics/parameters.py#L89