Adding the MacOS to CI - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

212 stars 82 forks source link

Adding the MacOS to CI #1713

Closed john-science closed 1 month ago

john-science commented 1 month ago

What is the change?

Adding the MacOS to CI.

Why is the change being made?

I recently found out that some of our users are Mac people.

Notes

I can not immediately get our unit tests working in Mac in parallel (something about our test temp directory logic breaks). So, this PR only runs the unit tests in series.
The Mac Unit Tests take 14 minutes to run. Is that too long?

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 1 month ago

I've got an old macbook air from grad school lying around if you ever need more mac-specific testing.

I borrowed my wife's Mac. But I'm sure I'd love a second tester. Up to you! But it sounds like we've had Mac testers at USNC for years.