Closed john-science closed 1 week ago
@drewejohnson @albeanth Both of you are Mac people, right?
Any ideas?
I just tested running the unit tests in parallel on my Mac and they work. I ran pytest -n 2 armi
and pytest -n 4 armi
, both work.
Maybe this is more of a GH actions issue?
I just tested running the unit tests in parallel on my Mac and they work. I ran
pytest -n 2 armi
andpytest -n 4 armi
, both work.Maybe this is more of a GH actions issue?
Thanks!
I have a PR up. Yeah, the problem that was popping up on GitHub Actions was also popping up for Arrielle on Windows if she run with -n 8
or higher.
I eventually found the runLog.py
fix in my PR that solved all problems.
Thanks for looking at it!
On GitHub CI, the unit tests are being run in serial on MacOS, but they would run faster if they were in parallel. So I would like to change this:
https://github.com/terrapower/armi/blob/86247a9f763949f802d32ff1f36beca6aa01292d/.github/workflows/mac_tests.yaml#L28
To this:
But the problem is something about our temp directory logic breaks in that case. You can see an example of the failures we will get here: