Fixing issue with _finalizeInteract in serial jobs - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

224 stars 87 forks source link

Fixing issue with _finalizeInteract in serial jobs #1730

Closed john-science closed 3 months ago

john-science commented 3 months ago

What is the change?

The new method OperatorMPI._finalizeInteract() does not work for serial jobs, this PR fixes that.

Why is the change being made?

A recent PR, a bug was introduced:

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 3 months ago

@zachmprince Just FYI, this is due to your recent PR.