Adding code coverage to FIXSRC code - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

224 stars 87 forks source link

Adding code coverage to FIXSRC code #1742

Closed john-science closed 3 months ago

john-science commented 3 months ago

What is the change?

Adding code coverage to FIXSRC code

Why is the change being made?

The DIF3D file format is important, and we have never had any unit tests for it.

Thanks to Aaron, for giving me the reference material I needed to understand the code.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 3 months ago

Just curious, is the code here a complete feature? Or does it need more to actually do something useful? Specifically the fixsrc.py file.

The actual code ARMI has to read and write FIXSRC files appears to be fully functional. Aaron gave me some test files (that are WAY too big to commit to the repo), and I was able to test code to my heart's content. But this isn't surprising, considering we actually used this code to drive DIF3D for years.