terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
212 stars 82 forks source link

We shouldn't be wiping the global elements durint tests #1743

Closed john-science closed 1 week ago

john-science commented 1 week ago

What is the change?

We have been calling elements.factory() during the unit tests, this PR removes that.

Why is the change being made?

In some of our downstream unit testing, which is significantly more parallel, wiping the global elements object from memory, even temporarily, can cause other unit tests to fail.

This has always been quite hard to track down, since it is an async bug that only happens very rarely. Happily, these calls were not necessary in the unit tests in the first place, so we can just remove them.


Checklist