search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
212 stars 82 forks source link

Make timesteps easier to search for in log file #1748

Open opotowsky opened 5 days ago

opotowsky commented 5 days ago

This is a double request, I guess. We can split the ticket if need be.

I often want a quick way to find which timestep I'm in during a sim, but it's a little hard to search for. Here's one example:

=========== 08 - criticalCrIteration            EveryNode - cycle 1, node 0 ===========

I can search for a few === signs to get to the last interface step to hit the log file, but there's no consistent way for me to search for the timestep. (cycle isn't the best search term). So we could get a creative about a universal way to get the timestep. But that is complicated by my next request, that the tight coupling iterations also display their timestep. Right now, they don't:

=========== 08 - criticalCrIteration            Coupled - iteration 0 ===========

So I have to page up quite a bit if I'm, e.g., in the 7th coupled iteration to get the the last timestep displayed.

Here is a possible suggestion (timestep or timenode or any other word could be used):

=========== 08 - criticalCrIteration            EveryNode - timestep: cycle 1, node 0 ===========
=========== 08 - criticalCrIteration            Coupled - timestep: cycle 1, node 0 -  iteration 0 ===========
opotowsky commented 5 days ago

@albeanth I seem to have a vague memory of you saying the second part of this request was either hard or impossible. Do you remember / can you give John a heads up on that?

keckler commented 5 days ago

+1 on the coupled iteration portion

albeanth commented 5 days ago

it's possible. it just requires an API change on operator.py

which I'm fine with, but sometimes people get wigged out with API changes 🤷

opotowsky commented 4 days ago

No API promises until v1.0 😉

albeanth commented 4 days ago

What would you all like the time steps to look like?

opotowsky commented 4 days ago

What would you all like the time steps to look like?

I don't have any strong feelings on this. I just would like to know there's a consistent way to search for the timestep.

john-science commented 1 day ago

@opotowsky I think you should add your suggestion for what this "should" look like to the ticket description. It's a good idea, and a really easy ticket for someone to take, once we fill in the detail. :)

opotowsky commented 1 hour ago

I repeat: I have no strong opinions here (I know how fiery this stuff can get). But here is a possible suggestion (timestep or timenode or any other word could be used):

=========== 08 - criticalCrIteration            EveryNode - timestep: cycle 1, node 0 ===========
=========== 08 - criticalCrIteration            Coupled - timestep: cycle 1, node 0 -  iteration 0 ===========

Oops, I see your comment. Adding to description. I'm only shy about adding a suggestion because folks get wild when vocab gets argued about!