terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
212 stars 82 forks source link

Clean up a minor bug in #1653 #1751

Closed mgjarrett closed 3 days ago

mgjarrett commented 4 days ago

What is the change?

Change logic in CrossSectionGroupManager to handle the case where BlockCollection._validRepresentativeBlockTypes is None.

Why is the change being made?

This logic was introduced in PR #1653. The logic checks for the length of _validRepresentativeBlockTypes, assuming it is always a list. It did not consider the case where _validRepresentativeBlockTypes is None.


Checklist

mgjarrett commented 4 days ago

@john-science this PR addresses a corner case bug in PR #1653 that wasn't caught until after it was merged.