Removing unused setting - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

214 stars 82 forks source link

Removing unused setting #1758

Closed john-science closed 2 days ago

john-science commented 3 days ago

What is the change?

This debug setting is entirely unused in the ecosystem, and so is being removed.

Why is the change being made?

This setting also has no description, which is causing unwanted log noise.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

john-science commented 3 days ago

@opotowsky No rush to review this. And (obviously):

I want to test this PR downstream before I merge.
- It passed! Our big, downstream testing system passed with this commit.
I am not going to interrupt our current high-priority work for this PR.