Removing custom density from refSmallReactorBase - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

224 stars 87 forks source link

Removing custom density from refSmallReactorBase #1760

Closed john-science closed 3 months ago

john-science commented 3 months ago

What is the change?

Removing a single line, that sets a single custom density on refSmallReactorBase.yaml.

Why is the change being made?

There is nothing intrinsically wrong with this idea, but it is causing some work downstream, and it doesn't really add anything to the model reactor.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.