Closed john-science closed 4 weeks ago
If the plan is to have the Reactor class also link to SFP and other ex-core structures, you could change Reactor
to Plant
or something. That's more accurate in the grand scheme of things.
That would be a much bigger headache of a change, but something to consider.
If the plan is to have the Reactor class also link to SFP and other ex-core structures, you could change
Reactor
toPlant
or something. That's more accurate in the grand scheme of things.
That's an idea. Someone else mentioned something similar to me. But, where do we draw the line at what is a "reactor"? Are the IVS and EVSTs part of the reactor?
Is there a technical definition that clearly divides "reactor" vs "plant"?
I am holding off on this change until the current ex-core PR is merged, so we don't have a merge conflict nightmare.
The
reactors.py
file is like 2700 lines long, and it contains:class Reactor
~ 200 linesclass Core
~ 2500 linesThere is a little cross-importing to handle, but we can sort that out easy enough.