terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
231 stars 89 forks source link

Move Core class to its own file #1869

Closed john-science closed 4 weeks ago

john-science commented 1 month ago

The reactors.py file is like 2700 lines long, and it contains:

There is a little cross-importing to handle, but we can sort that out easy enough.

albeanth commented 1 month ago

If the plan is to have the Reactor class also link to SFP and other ex-core structures, you could change Reactor to Plant or something. That's more accurate in the grand scheme of things.

That would be a much bigger headache of a change, but something to consider.

john-science commented 1 month ago

If the plan is to have the Reactor class also link to SFP and other ex-core structures, you could change Reactor to Plant or something. That's more accurate in the grand scheme of things.

That's an idea. Someone else mentioned something similar to me. But, where do we draw the line at what is a "reactor"? Are the IVS and EVSTs part of the reactor?

Is there a technical definition that clearly divides "reactor" vs "plant"?

john-science commented 1 month ago

I am holding off on this change until the current ex-core PR is merged, so we don't have a merge conflict nightmare.