search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
224 stars 87 forks source link

Why is settingsValidation under operators? #1880

Open john-science opened 2 weeks ago

john-science commented 2 weeks ago

The tools we use to validate settings come from th Query class, which is in settingsValidation.py.

But that file is at: armi/operators/settingsValidation.py, for some reason.

Surely that should be under armi/settings/, right?

john-science commented 1 week ago

Ouch. I just checked, and this API-breaking import is used widely downstream.

So, to provide a more stable API, this change will have to first involve a DeprecationWarning, and then a very long intermediate period before the change is made final.

keckler commented 5 days ago

Seems duplicate of #1464 , no?

john-science commented 5 days ago

Seems duplicate of #1464 , no?

You're right! Thanks!