search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
228 stars 90 forks source link

Update spatial locations after HexBlock.rotate #1939

Open drewj-tp opened 1 week ago

drewj-tp commented 1 week ago

Replaces #1860 because a decision has been made to not rotate data parameters. Instead

  1. update the spatial location of components through rotation.
  2. enforce that, for pin-like data parameters like Block.p.linPowByPin, the data at index i is defined at Block.getPinCoords()[i],
  3. setters like Block.setPinPowers are no longer needed and just set the data parameter directly.
  4. discourage the usage of Block.p.pinLocation
drewj-tp commented 1 week ago

@john-science has thoughts on updating the Block.grid object through rotation, which feels appropriate to bring up here. Namely we should update the Block.grid