search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
231 stars 89 forks source link

tabulate still included as dependency even though it's internalized #1944

Closed drewj-tp closed 2 weeks ago

drewj-tp commented 3 weeks ago

Still picked up with pip install . because it's in the pyproject.toml

https://github.com/terrapower/armi/blob/c6f46e5d04dc265e7a8e470fdd1977c9a4e16e3e/pyproject.toml#L48

But we incorporated tabulate into armi.utils.tabulate in #1811 // #1749

opotowsky commented 3 weeks ago

Wow eagle eye!

We left it in while downstream plugins were being converted. It is finally ready for removal as of today!

john-science commented 2 weeks ago

Thanks Drew!

As Arrielle said, this was not a ticket because the purpose for leaving that dependency is internal and not to be discussed in this venue. And it will be removed today.

john-science commented 2 weeks ago

This ticket was closed with the PR: https://github.com/terrapower/armi/pull/1948