search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
228 stars 90 forks source link

Provide a method for determining center locations of children on a block #1956

Open drewj-tp opened 6 days ago

drewj-tp commented 6 days ago

I know this isn't part of your design, but maybe this method could take an optional flag parameter that defaults to Flags.CLAD. That way, if in the future someone wants to use some other flag to identify what they want to define as a "pin".

This request is scope creep, but it seems like a one-line change and a single unit test to make this more extensible in ways that you have convinced me are important.

Thoughts?

_Originally posted by @john-science in https://github.com/terrapower/armi/pull/1943#discussion_r1801672349_

john-science commented 5 days ago

This was originally a comment on Block.getPinLocations(), to just add a input flag to make this method more flexible.