search

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
236 stars 90 forks source link

Further issues found with the EOL being written to the Database #1960

Open john-science opened 1 month ago

john-science commented 1 month ago

@albeanth and I identified two places where the ARMI codebase does not support the new EOL time point being written to the database (added in PR 1090):

  1. Database3.genTimeSteps():

https://github.com/terrapower/armi/blob/8b5163a8b61ebe704419d2d77067bfcf8018f328/armi/bookkeeping/db/database3.py#L612

Returns (cycle, node), but if the EOL is present in the DB, it just returns the last time node twice.

  1. Database3.load() takes in cycle and node as integers, thus not allowing us to load an EOL timestep:

https://github.com/terrapower/armi/blob/8b5163a8b61ebe704419d2d77067bfcf8018f328/armi/bookkeeping/db/database3.py#L702

albeanth commented 1 month ago

Cross-referencing #1090 since it's related.