Open keckler opened 1 month ago
Looks like the CrossSectionGroupManager
is assuming zero-indexing:
https://github.com/terrapower/armi/blob/eef58ddcd797c7acc542a4941b95dcb84dda2670/armi/physics/neutronics/crossSectionGroupManager.py#L938-L972
The LatticePhysicsInterface
also assumes zero-indexing:
https://github.com/terrapower/armi/blob/eef58ddcd797c7acc542a4941b95dcb84dda2670/armi/physics/neutronics/latticePhysics/latticePhysicsInterface.py#L224-L257
I'm not sure that anything important is actually broken here, so I removed the "bug" label. But I'd say this is confusing and I would advocate that the value used and the value printed are aligned with each other.
The "Tight Coupling Convergence Summary" table is also zero-indexed:
So it really seems like everything except for the interaction hook header is zero-indexed. Seems like an easy fix to just change the headers.
In the code chunk below, we store
coupledIteration
asn+1
, whereas we sendn
intointeractAllCOupled()
: https://github.com/terrapower/armi/blob/eef58ddcd797c7acc542a4941b95dcb84dda2670/armi/operators/operator.py#L456-L458This also means that the iteration number that is printed in the STDOUT is not aligned with the value used during
interactCoupled()
calls. In the screenshot below, the circled value comes from the DB. https://github.com/terrapower/armi/blob/eef58ddcd797c7acc542a4941b95dcb84dda2670/armi/operators/operator.py#L568-L573So basically, if anyone is trying to do something within an
interactCoupled()
call that is dependent on the iteration number, they are possibly using the wrong iteration number if they are using the STDOUT as their guide.