terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
233 stars 90 forks source link

Use ENDF/B-VII.1 MC2-3 nuclide IDs #1982

Closed aaronjamesreynolds closed 2 weeks ago

aaronjamesreynolds commented 3 weeks ago

What is the change?

Currently, ARMI returns MC2-3 nuclide IDs consistent with the ENDF/B-VII.0 library. This PR makes it so that:

This paper provides a good overview of the differences between VII.0 and VII.1.

Tests have been updated or created to verify that getMcc3Id(), getMcc3IdEndfVII0(), and getMcc3IdEndfVII1() return the expected IDs. Additionally, two tests (test_compareDatabaseSim() and setUp() [for the cross section manager]) needed to be updated since vanadium is elemental in VII.0 and isotopic in VII.1.

Why is the change being made?

ENDF/B-VII.1 contains updated evaluations and entirely new evaluations compared to ENDF/B-VII.0. ANL has recently released VII.1-based MC2-3 libraries, so the most recent available data is the sensible default.


Checklist

CLAassistant commented 3 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

:white_check_mark: john-science
:x: Aaron Reynolds
:x: aaronjamesreynolds


Aaron Reynolds seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.