Closed aaronjamesreynolds closed 2 weeks ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.
:white_check_mark: john-science
:x: Aaron Reynolds
:x: aaronjamesreynolds
What is the change?
Currently, ARMI returns MC2-3 nuclide IDs consistent with the ENDF/B-VII.0 library. This PR makes it so that:
mcc-nuclides.yaml
,getMcc3Id()
or indexing thebyMcc3Id
dictionary) is consistent with ENDF/B-VII.1, andgetMcc3IdEndfVII0()
or indexing thebyMcc3IdEndfVII0
dictionary.This paper provides a good overview of the differences between VII.0 and VII.1.
Tests have been updated or created to verify that
getMcc3Id()
,getMcc3IdEndfVII0()
, andgetMcc3IdEndfVII1()
return the expected IDs. Additionally, two tests (test_compareDatabaseSim()
andsetUp()
[for the cross section manager]) needed to be updated since vanadium is elemental in VII.0 and isotopic in VII.1.Why is the change being made?
ENDF/B-VII.1 contains updated evaluations and entirely new evaluations compared to ENDF/B-VII.0. ANL has recently released VII.1-based MC2-3 libraries, so the most recent available data is the sensible default.
Checklist
doc
folder.pyproject.toml
.