terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
233 stars 90 forks source link

Update `copyOrWarn` and `getFileSHA1Hash` to account for directories #1984

Closed opotowsky closed 3 weeks ago

opotowsky commented 3 weeks ago

What is the change?

copyOrWarn can now handle directories. This also includes an edit to getFileSHA1Hash so that it can handle directories too.

Why is the change being made?

Sometimes a directory needs to be copied too. Let's give the directories the attention they deserve!

This supports a case setting downstream that is a directory, not a file path.


Checklist

john-science commented 3 weeks ago

Hey Arrielle! Can you re-run the linters?

Thanks!

opotowsky commented 3 weeks ago

(working on some tests now + fixing some code, so this isn't quite ready yet)

Update @john-science : it's ready for review. I have a few comments and questions for you.