terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality
https://terrapower.github.io/armi/
Apache License 2.0
233 stars 89 forks source link

Cleaning out unnecessary uses of r.o #1999

Closed john-science closed 3 days ago

john-science commented 3 weeks ago

What is the change?

Here I clean out all the unnecessary usages of r.o.

(I also remove the CustomModifier class, which is entirely unused in ARMI or anywhere downstream. I checked. And it was a major user of r.o.)

Why is the change being made?

This PR is progress towards, but not a complete picture of Jake's ticket to completely remove the Operator from the Reactor; #830.

What this PR leaves is the central usage and problem to solve the r.o problem, the fact that our Interface class just throws around r.o and o.r willy nilly:

https://github.com/terrapower/armi/blob/e777af7c9d01b938cfdc7949de348627a3821087/armi/interfaces.py#L338


Checklist