Sort out parameters - Githubissues

terrapower / armi

An open-source nuclear reactor analysis automation framework that helps design teams increase efficiency and quality

https://terrapower.github.io/armi/

Apache License 2.0

234 stars 89 forks source link

Sort out parameters #995

Open keckler opened 2 years ago

keckler commented 2 years ago

I've noticed a handful of error/inconsistencies/deficiencies in the block parameters. This is a running list for me to fix:

[ ] Specify that multigroup fluxes are volume-integrated in their descriptions
[x] Units of extSrc in the neutronics parameters look fishy
[ ] There are a handful of parameters that are "cumulative over cycle" as compared to just "cumulative", but some of these seem inconsistently labeled
[ ] The categories labels in the neutronics parameters do not use the flags from the Category class, but they should
[ ] Some of the parameters from the blocksParameters module also don't use the flags from the Category class, but they should (this is probably a more widespread problem)
[ ] In the parameterDefinitions.Category class, we are lacking a cumulative attribute even though many parameters are marked as "cumulative"

john-science commented 2 years ago

Generally I like it.

But this one:

Some of the parameters from the blocksParameters module also don't use the flags from the Category class, but they should

We do not demand that each Parameter has a Category. And I don't think we should.

keckler commented 1 year ago

Hm, yeah, sorry I was being a bit sloppy with that. What I mean is, for example instances like this: https://github.com/terrapower/armi/blob/1a6cb85adc900bcf531d5749367269acfe8cf9d3/armi/physics/neutronics/parameters.py#L679-L685

That parameter has a categories entry, but it is just a string. It should pull its category from the Category class, when that is possible.

john-science commented 1 year ago

@keckler Any updates on this ticket, after all the Parameter work from two weeks ago?

keckler commented 1 year ago

@john-science I see that one of the items was addressed, so I marked it as such just now. But most of those boxes are still open just because they weren't the focus of any of those recent PRs.

Thanks for pinging!

john-science commented 8 months ago

@keckler This ticket is still assigned to you. That's cool with me, but if you aren't planning on working on it, please un-assign it.

(You are not being singled out, I am going through all the ARMI tickets.)

keckler commented 8 months ago

Done!