search

terraref / brapi

Breeder's API implementation for TERRA-REF
https://terraref.org/brapi/v1/calls
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Add logging #12

Closed tcnichol closed 5 years ago

tcnichol commented 5 years ago

This pull request adds a logger (plus several log statements) in brapi.

Not sure if it is correct, feedback needed.

dlebauer commented 5 years ago

This seems to have the same changes as #10 along with the new logging ... perhaps it would make more sense to have the issue-537/cultivar-treatment-siteclear branch be the base for the pr instead of off master?

robkooper commented 5 years ago

@tcnichol merging this request, but you are making changes to the logging branch that should be happening on the original branch. Please make changes from now on the issue-537/cultivar-treatment-siteclear branch

robkooper commented 5 years ago

Actually can't merge due to conflict, can you fix conflict and then just merge.

robkooper commented 5 years ago

@tcnichol this seems to have more than just logging, what was else was done and why?

robkooper commented 5 years ago

Working on a large rewrite of code, not sure what this does and how it needs to be incorperated in rewrite.

tcnichol commented 5 years ago

Rob.

Some of the other stuff was that this was built off the other brapi pull request adding the new endpoints.

This just changes how logging is done, using an actual logger instead of print statements. I think it would be best that I decline this pull request, and if the feature is still wanted I can create a new one against master that would be easier to merge.

tcnichol commented 5 years ago

this was built off an earlier branch and many of the changes no longer make sense so i am closing this one without mergin.