search

terraref / brapi

Breeder's API implementation for TERRA-REF
https://terraref.org/brapi/v1/calls
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Ensure that all implemented endpoints are compliant #17

Closed dlebauer closed 5 years ago

dlebauer commented 5 years ago
  1. test against http://webapps.ipk-gatersleben.de/brapivalidator/
  2. set up continuous integration to
    • ensure that endpoints are complaint
    • require PRs to pass compliance (and other!) tests
dlebauer commented 5 years ago

From @BrapiCoordinatorSelby

Yes, the BRAVA ui controls the backend via APIs, but those APIs are not documented. take a look at SingleTestResource.java https://github.com/plantbreeding/IPK-BrAPI-Validator

robkooper commented 5 years ago

Created a container that is part of the docker-compose. You can use it with either the docker container if you use http://brapi:5000/brapi/v1 or you can use it when you run it in the editor/local machine by using http://host.docker.internal:5000/brapi/v1 as the URL.

BrapiCoordinatorSelby commented 5 years ago

FYI, the IPK guys put an image of BRAVA up on DockerHub, if that makes your CI process easier. https://hub.docker.com/r/ipkbit/brapi-validator @robkooper I'm not sure if this was built using your docker file pull request, or one they made themselves.

robkooper commented 5 years ago

That might be very likely: https://github.com/plantbreeding/IPK-BrAPI-Validator/pull/37 got merged today.